Re: [PATCH] crypto: sha{256,512}_ssse3 - remove asmlinkage from static functions

[H. Peter Anvin]

On 04/17/2014 08:28 AM, Marek Vasut wrote:
> On Wednesday, April 16, 2014 at 06:19:50 PM, Jianyu Zhan wrote:
>> Commit 128ea04a9885("lto: Make asmlinkage __visible") restricts
>> asmlinkage to externally_visible, this causes compilation warnings:
>>
>>     arch/x86/crypto/sha256_ssse3_glue.c:56:1:
>>     warning: âexternally_visibleâ attribute have effect only on public
>> objects [-Wattributes]
>>
>>     static asmlinkage void (*sha256_transform_asm)(const char *, u32 *,
>> u64); ^
>>
>>     arch/x86/crypto/sha512_ssse3_glue.c:55:1:
>>     warning: âexternally_visibleâ attribute have effect only on public
>> objects [-Wattributes] static asmlinkage void
>> (*sha512_transform_asm)(const char *, u64 *, ^
>>
>> Drop asmlinkage here to avoid such warnings.
>>
>> Also see Commit 8783dd3a37a5853689e1("irqchip: Remove asmlinkage from
>> static functions")
>>
>> Signed-off-by: Jianyu Zhan <nasa4836@xxxxxxxxx>
> 
> Makes sense, please add my humble
> 
> Reviewed-by: Marek Vasut <marex@xxxxxxx>
> 

It doesn't make sense, sorry.  The right thing to drop here is not
"asmlinkage", it is "static": this is an external declaration.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/