Re: [PATCH 2/2] nohz: use delayed iowait accounting to avoid race on idle time stats

[Peter Zijlstra]

On Fri, Apr 18, 2014 at 02:52:05PM +0900, Hidetoshi Seto wrote:
> I think it also works... but I have some concerns here:
> 
>  - it changes golden path in scheduler core.
>     impact for performance is questionable.

We should be able to measure that, but like said, it shouldn't change
the number of atomic ops and makes sure its all in the same cacheline,
so the additional code is all cheap.

>  - it forces managing last_iowait even if system is in busy
>     I guess it will drop max performance of the system
>     while my proposed fix only touches procedure for idle
>     with nohz. 

That could be fixed by looking to see if the remote rq is idle.

> By the way, I have posted my v4 patch set:
> https://lkml.org/lkml/2014/4/17/120
> 
> I'll happy if you could give your comments on it too!

Yeah, I saw that, didn't have time yet, will hopefully get to it soon
:-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/