RE: PROBLEM: Fatal Machine Check >= 3.13.5-101.fc19.x86_64
From: Deucher, Alexander
Date: Fri Apr 18 2014 - 09:08:58 EST
> -----Original Message-----
> From: Matthias Graf [mailto:matthias.graf@xxxxxxxxxx]
> Sent: Friday, April 18, 2014 7:46 AM
> To: Borislav Petkov
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Tony Luck; Deucher, Alexander
> Subject: Re: PROBLEM: Fatal Machine Check >= 3.13.5-101.fc19.x86_64
>
> I applied your patch to linus' current master (3.15.0-rc1+) and indeed
> it does solve the issue for me!
>
> Thanks for your help.
>
> I would appreciated if you keep me posted on updates.
You can try some testing patches here:
https://bugs.freedesktop.org/show_bug.cgi?id=76286
but for now, I'm just going to disable dpm on rv770 asics.
Alex
>
> Best,
> Matthias
>
> Am 18.04.2014 11:45, schrieb Borislav Petkov:
> > On Fri, Apr 18, 2014 at 11:17:34AM +0200, Matthias Graf wrote:
> >> Fine-grained bisection result:
> >>
> >> ab70b1dde73ff4525c3cd51090c233482c50f217 is the first bad commit
> >> commit ab70b1dde73ff4525c3cd51090c233482c50f217
> >> Author: Alex Deucher <alexander.deucher@xxxxxxx>
> >> Date: Fri Nov 1 15:16:02 2013 -0400
> >>
> >> drm/radeon: enable DPM by default on r7xx asics
> >>
> >> Seems to be stable on them.
> >>
> >> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> >>
> >> :040000 040000 f3262029b868df4d882f64b4deba6b9230e307ea
> >> 1f1dfca42763703a56e3cc82bb103608a24be94e M drivers
> >>
> >>
> >> Result is reasonable: I have a RV770 chip.
> >
> > Yes it is.
> >
> >> (Additional) Bug Report for Reference:
> >> https://bugzilla.redhat.com/show_bug.cgi?id=1085785
> >>
> >> Thanks for the instructions Borislav! At first, I was not completely
> >> sure what you expected me to do (this is my first kernel bug report :)).
> >
> > And you're doing good so far! :-)
> >
> >> If there is anymore more I can help you with, let me know.
> >
> > Ok, now we want to confirm that this patch is *actually* the culprit by
> > reverting it. Simply pull Linus' master branch to have the latest tree,
> > and then do:
> >
> > $ git checkout -b radeon-revert master
> >
> > so that you land on a throwaway branch where we can play. Then normally
> you
> > would do
> >
> > $ git revert ab70b1dde73ff4525c3cd51090c233482c50f217
> >
> > but that causes conflicts so I did it for you, see below. Simply apply
> > this patch ontop *without* doing the revert with git. Then build, boot
> > and test. We want to see whether it still generates those ROB timeout
> > machine checks. If all looks ok, then we're pretty sure we need to talk
> > about DPM with your GPU on your platform with Alex. :-)
> >
> > Feel free to ask any questions should something be not clear.
> >
> > Thanks.
> >
> > ---
> > From 0790e872f6d3c986d9ed36b850fd9d799dc422f9 Mon Sep 17 00:00:00
> 2001
> > From: Borislav Petkov <bp@xxxxxxx>
> > Date: Fri, 18 Apr 2014 11:43:12 +0200
> > Subject: [PATCH] Revert "drm/radeon: enable DPM by default on r7xx
> asics"
> >
> > This reverts commit ab70b1dde73ff4525c3cd51090c233482c50f217.
> >
> > Conflicts:
> > drivers/gpu/drm/radeon/radeon_pm.c
> > ---
> > drivers/gpu/drm/radeon/radeon_pm.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_pm.c
> b/drivers/gpu/drm/radeon/radeon_pm.c
> > index ee738a524639..af693c4746da 100644
> > --- a/drivers/gpu/drm/radeon/radeon_pm.c
> > +++ b/drivers/gpu/drm/radeon/radeon_pm.c
> > @@ -1257,6 +1257,10 @@ int radeon_pm_init(struct radeon_device *rdev)
> > case CHIP_RV670:
> > case CHIP_RS780:
> > case CHIP_RS880:
> > + case CHIP_RV770:
> > + case CHIP_RV730:
> > + case CHIP_RV710:
> > + case CHIP_RV740:
> > case CHIP_BARTS:
> > case CHIP_TURKS:
> > case CHIP_CAICOS:
> > @@ -1273,10 +1277,6 @@ int radeon_pm_init(struct radeon_device *rdev)
> > else
> > rdev->pm.pm_method = PM_METHOD_PROFILE;
> > break;
> > - case CHIP_RV770:
> > - case CHIP_RV730:
> > - case CHIP_RV710:
> > - case CHIP_RV740:
> > case CHIP_CEDAR:
> > case CHIP_REDWOOD:
> > case CHIP_JUNIPER:
> >