Re: [PATCH v2 2/2] regmap: i2c: fallback to SMBus if the adapter does not support standard I2C

From: Mark Brown
Date: Fri Apr 18 2014 - 11:11:38 EST


On Thu, Apr 17, 2014 at 11:40:12AM +0200, Boris BREZILLON wrote:

> +const struct regmap_bus *regmap_get_i2c_bus(struct i2c_client *i2c,
> + const struct regmap_config *config)

Non-exported functions should be static. Otherwise this looks good
modulo the register size issue that Guenter identified.

Attachment: signature.asc
Description: Digital signature