Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts
From: Russell King - ARM Linux
Date: Fri Apr 18 2014 - 19:19:32 EST
On Fri, Apr 18, 2014 at 02:37:51PM -0700, Tony Lindgren wrote:
> * Thierry Reding <thierry.reding@xxxxxxxxx> [140411 11:40]:
> > On Fri, Apr 11, 2014 at 10:20:28AM +0100, Russell King - ARM Linux wrote:
> > > So what happens if a device driver probe function:
> > >
> > > - creates a new platform device
> > > - copies the resources from the original to the new device
> > > - copies the of_node from the original to the new device
> > > - registers the new device
> > >
> > > Yes, it's broken (because it can result in the same driver being re-probed
> > > by the new device) but we *do* have stuff in the kernel tree which does
> > > this.
>
> Grr. Care to list some examples? See also if what I'm suggesting below
> if that might work for the cases you're describing.
Until recently, ahci_imx did exactly this, but that's been fixed now
(by reworking ahci into a library.) I'm not immediately aware of any
other drivers pulling this trick.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/