Re: [PATCHv3 05/14] HSI: Add channel resource support to HSI clients

[Pavel Machek]

Hi!

> Make HSI channel ids platform data, which can be provided
> by platform data.
>

>  static void hsi_client_release(struct device *dev)
>  {
> -	kfree(to_hsi_client(dev));
> +	struct hsi_client *cl = to_hsi_client(dev);
> +
> +	if (cl->tx_cfg.channels)
> +		kfree(cl->tx_cfg.channels);
> +	if (cl->rx_cfg.channels && cl->rx_cfg.channels != cl->tx_cfg.channels)
> +		kfree(cl->rx_cfg.channels);
> +
> +	kfree(cl);

Can cl->rx_cfg.channels == cl->tx_cfg.channels happen? That seems like
quite a hack :-(.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/