Re: [PATCHv2 3/9] mfd: twl4030-madc: Cleanup driver

From: Pavel Machek
Date: Sun Apr 20 2014 - 11:54:19 EST


Hi!

> Some style fixes in twl4030-madc driver.
>
> Reported-by: Jonathan Cameron <jic23@xxxxxxxxxx>
> Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx>
> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>

Reviewed-by: Pavel Machek <pavel@xxxxxx>


> @@ -665,10 +660,6 @@ out:
> }
> EXPORT_SYMBOL_GPL(twl4030_madc_conversion);
>
> -/*
> - * Return channel value
> - * Or < 0 on failure.
> - */
> int twl4030_get_madc_conversion(int channel_no)
> {
> struct twl4030_madc_request req;

Maybe I'd put the comment on one line, but it seems useful...?

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/