Re: [PATCH 12/12] cgroup: implement dynamic subtree controller enable/disable on the default hierarchy

[Raghavendra K T]

On 04/19/2014 02:11 AM, Tejun Heo wrote:
> Hello,
>
> On Thu, Apr 17, 2014 at 11:33:50PM +0530, Raghavendra KT wrote:
> > On Tue, Apr 15, 2014 at 3:07 AM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> > I undertsand that with the above parsing we could do
> > echo "-blkio +blkio" > cgroup.subtree_control and honor last enable/disable.
>
> Yeah, and the behavior is described in the following document.

Hello Tejun, Thanks for the kind reply. The document has helped me a
lot while reviewing,testing the unified hierarchy code.

>   http://lkml.kernel.org/g/20140416145248.GD1257@xxxxxxxxxxxxxx
>
> > It confused me while testing. do you think we should return -EINVAL in
> > such case?
>
> Hmmm... I think whatever comes later wins is a pretty clear and easy
> rule, no?

Very much correct. and if there is a feeling to check multiple entry
later I would happy to update the code.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/