Re: [PATCH] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework

[Vivek Gautam]

On Thu, Apr 10, 2014 at 6:54 PM, Vivek Gautam <gautam.vivek@xxxxxxxxxxx> wrote:
> Add support to consume phy provided by Generic phy framework.
> Keeping the support for older usb-phy intact right now, in order
> to prevent any functionality break in absence of relevant
> device tree side change for ohci-exynos.
> Once we move to new phy in the device nodes for ohci, we can
> remove the support for older phys.

Any comments on this please.
I think whatever the approach we follow, that can be common to both
ehci-exynos[1], and ohci-exynos, since
both are needed to move to the new generic phy framework, keeping
support for older usb-phy
so as to have smooth transition, in order to avoid any regression.

> Signed-off-by: Vivek Gautam <gautam.vivek@xxxxxxxxxxx>
> Cc: Jingoo Han <jg1.han@xxxxxxxxxxx>
> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> ---
>
> Based on 'usb-next' branch of Greg's usb tree.
> Tested with local dt patches, similar to ehci dt changes posted by Kamil[1].
> Tested on Exynos5250 smdk.
>
 [1] [PATCH v6 4/8] dts: Add usb2phy to Exynos 5250
     https://lkml.org/lkml/2014/1/29/302
>
>  .../devicetree/bindings/usb/exynos-usb.txt         |   14 ++++
>  drivers/usb/host/ohci-exynos.c                     |   79 ++++++++++++++++++--
>  2 files changed, 85 insertions(+), 8 deletions(-)
>
[snip]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/