RE: [PATCH v7 1/2] can: xilinx CAN controller support

[Appana Durga Kedareswara Rao]

Hi Marc,


> -----Original Message-----
> From: Marc Kleine-Budde [mailto:mkl@xxxxxxxxxxxxxx]
> Sent: Tuesday, April 22, 2014 2:29 PM
> To: Appana Durga Kedareswara Rao; monstr@xxxxxxxxx
> Cc: wg@xxxxxxxxxxxxxx; Michal Simek; grant.likely@xxxxxxxxxx;
> robh+dt@xxxxxxxxxx; linux-can@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v7 1/2] can: xilinx CAN controller support
>
> On 04/22/2014 09:56 AM, Appana Durga Kedareswara Rao wrote:
> > Hi Marc,
> >
> >> -----Original Message-----
> >> From: Michal Simek [mailto:monstr@xxxxxxxxx]
> >> Sent: Monday, April 07, 2014 12:27 PM
> >> To: Appana Durga Kedareswara Rao
> >> Cc: wg@xxxxxxxxxxxxxx; mkl@xxxxxxxxxxxxxx; Michal Simek;
> >> grant.likely@xxxxxxxxxx; robh+dt@xxxxxxxxxx;
> >> linux-can@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> >> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux- kernel@xxxxxxxxxxxxxxx;
> >> devicetree@xxxxxxxxxxxxxxx; Appana Durga Kedareswara Rao
> >> Subject: Re: [PATCH v7 1/2] can: xilinx CAN controller support
> >>
> >> On 04/02/2014 03:13 PM, Kedareswara rao Appana wrote:
> >>> This patch adds xilinx CAN controller support.
> >>> This driver supports both ZYNQ CANPS and Soft IP AXI CAN controller.
> >>>
> >>> Signed-off-by: Kedareswara rao Appana <appanad@xxxxxxxxxx>
> >>> ---
> >>> Changes for v7:
> >>> - Updated the driver with review comments.
> >>> - Moved the driver bindings doc as a separte patch.
> >>> Changes for v6:
> >>> - Updated the driver with review comments.
> >>> - Used the clock names specified in the data sheet.
> >>> - Updated the devicetree bindings doc as per Rob suggestion.
> >>> Changes for v5:
> >>> - Updated the driver with the review comments.
> >>> - Remove the check for the tx fifo full interrupt condition
> >>>   form Tx interrupt routine as we are checking it in the _xmit
> >>>   routine.
> >>> - Clearing the txok interrupt in the tx interrupt routine for
> >>>   every Tx can frame.
> >>> Changes for v4:
> >>> - Added check for the tx fifo full interrupt condition in Tx
> >>> interrupt routine.
> >>> - Added be iohelper functions.
> >>> - Moved the clock enable/disable to probe/remove because of
> >>>   Added big endian support for AXI CAN controller case(reading
> >>>   a register during probe for that we need to enable clock).
> >>> Changes for v3:
> >>> - Updated the driver with the review comments.
> >>> - Modified the tranmit logic as per Marc suggestion.
> >>> - Enabling the clock when the interface is up to reduce the
> >>>   Power consumption.
> >>> Changes for v2:
> >>> - Updated with the review comments.
> >>> - Removed the unnecessary debug prints.
> >>> - include tx,rx fifo depths in ZYNQ CANPS case also
> >>> ---
> >>>  drivers/net/can/Kconfig      |    7 +
> >>>  drivers/net/can/Makefile     |    1 +
> >>>  drivers/net/can/xilinx_can.c | 1176
> >>> ++++++++++++++++++++++++++++++++++++++++++
> >>>  3 files changed, 1184 insertions(+), 0 deletions(-)  create mode
> >>> 100644 drivers/net/can/xilinx_can.c
> >>
> >> Mark: Any update on this one?
> >> BTW: When you apply these patches you should apply 2/2 before 1/2.
> >> There is new checking for binding.
> >>
> >
> > Ping?
>
> Done, when you repost, can you change the order of the patches, so that the
> binding comes first.
>
Ok Sure.

Regards,
Kedar.

> Marc
>
> --
> Pengutronix e.K.                  | Marc Kleine-Budde           |
> Industrial Linux Solutions        | Phone: +49-231-2826-924     |
> Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.