Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

[Larry Finger]

On 04/22/2014 09:14 AM, Dan Carpenter wrote:
> On Tue, Apr 22, 2014 at 07:31:50PM +0530, navin patidar wrote:
> > Hi dan
> >
> > it's just a cleanup patch and i also tested all patches of this patch
> > series on the hardware (TP-LINK  TL-WN723N).
> > my mistake i should have added "Tested-by" tag for all patches.
> >
> > Tested-by: navin patidar <navin.patidar@xxxxxxxxx>
>
> No no.  It's not necesary to add a tested by to everything.  It was just
> something I was curious about.  The patches looked ok.  If you hadn't
> tested them I would review them a second time more carefully.

To me, the opposite case is true. If you have not tested, then you need to 
explicitly state "compile tested only" in the commit message. Without saying 
that, your signed-off-by is implying that you have tested, as well as declaring 
that you own the copyright to the material.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/