Re: [PATCH 2/2] spi/pxa2xx-pci: Pass host clock rate info from PCI glue layer

From: Mark Brown
Date: Tue Apr 22 2014 - 14:22:28 EST


On Tue, Apr 22, 2014 at 03:27:23PM +0100, One Thousand Gnomes wrote:
> > Why is this conditional? It's really unhelpful for writing generic code
> > handling clocks that the API isn't available as standard. Allowing the
> > user to disable it if it's not required makes sense but not making it
> > available at all is just unhelpful.

> KConfig allows drivers to select features they need - this seems to be a
> non issue ?

No, not for the clock API - the platform has to provide a clock API
since currently platforms still have the option of providing their own
implementation. We should fix that (just making the common clock API
available on all platforms which don't have a custom one would help a
lot) but getting anyone to take any interest has been hard.

Attachment: signature.asc
Description: Digital signature