Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Rob Herring]

On Tue, Apr 22, 2014 at 1:47 PM, Rob Herring <robherring2@xxxxxxxxx> wrote:
> On Tue, Apr 22, 2014 at 10:38 AM, Antoine TÃnart
> <antoine.tenart@xxxxxxxxxxxxxxxxxx> wrote:
>> Add support for the Berlin SoCs AHCI SATA controller allowing to
>> interface with devices like external hard drives.

One more thing.

>> +       nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
>> +
>> +       /* force_map is modified only if the property is found */
>> +       of_property_read_u32(np, "marvell,force-port-map", &force_map);

This property does not appear to be documented.

>> +       if (force_map)
>> +               nports = force_map;

You don't need this as your comment says, you can just do:

of_property_read_u32(np, "marvell,force-port-map", &nports);

nports will only be changed if property is present.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/