Re: [PATCH 0/4 V3] Print traces on softlockup

[Don Zickus]

On Tue, Apr 22, 2014 at 11:28:28AM -0700, Andrew Morton wrote:
> On Tue, 22 Apr 2014 11:17:24 -0400 Don Zickus <dzickus@xxxxxxxxxx> wrote:
> 
> > Added more patches to handle the 'uniprocessor' panic case by sending NMIs
> > to every cpu but self.  Only affects x86, sparc.
> > 
> 
> Looks OK to me.  A couple of things:
> 
> - Patches 1-3 should be combined so we don't create bisection holes
>   due to x86 and sparc build errors.

ok.

> 
> - Patch 4 adds stuff which is unusable on uniprocessor, especially
>   the presence of /proc/sys/kernel/softlockup_all_cpu_backtrace.  We
>   already have #ifdef CONFIG_SMP in kern_table, so do more of that?

I can resubmit that patch with CONFIG_SMP around each piece of that patch.

Thanks for the review.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/