Re: [PATCH 06/28] nios2: Memory management

[LF.Tan]

On Wed, Apr 23, 2014 at 12:24 AM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
>> Other than being "pretty" the above fix is to remove a mismatch type
>> warning. You can get rid of the warning in different ways:
>>
>> ifdef __ASSEMBLY__
>> define PAGE_SIZE       4096
>> else
>> define PAGE_SIZE       4096UL
>> endif
>
> The usual way to do this is as follows:
> #include <linux/const.h>
>
> #define PAGE_SHIFT   12
> #define PAGE_SIZE    (_AC(1, UL) << PAGE_SHIFT)
> #define PAGE_MASK    (~(PAGE_SIZE-1))
>
> _AC(1, UL) expands to 1 for assembler and 1UL for C code.
>
> This is also what was suggested above.
>
> Please follow this scheme for nios2 too.
>
>         Sam
Sure, will change to this way.

Thanks.

Ley Foon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/