Re: [PATCH 23/28] nios2: Nios2 registers

[Ley Foon Tan]

Hi Tobias


On Tue, Apr 22, 2014 at 8:39 PM, Tobias Klauser <tklauser@xxxxxxxxxx> wrote:
> On 2014-04-18 at 14:27:06 +0200, Ley Foon Tan <lftan@xxxxxxxxxx> wrote:

>> +
>> +/* estatus register bits */
>> +#define ESTATUS_EPIE (1 << 0)        /* processor interrupt enable */
>> +#define ESTATUS_EU   (1 << 1)        /* user mode */
>> +#define ESTATUS_EH   (1 << 2)        /* Exception mode */
>> +
>> +/* tlbmisc register bits */
>> +#define TLBMISC_PID_SHIFT    4
>> +#define TLBMISC_PID_MASK     ((1UL << cpuinfo.tlb_pid_num_bits) - 1)
>
> You should probably #include <asm/cpuinfo.h> here since struct cpuinfo
> is used in the definition.
Okay, but I think we should add #ifndef __ASSEMBLY__ at #include
<asm/cpuinfo.h> and at line #define TLBMISC_PID_MASK.
Assembly source file might include this file as well.

>
>> +#define TLBMISC_WAY_MASK     0xf
>> +#define TLBMISC_WAY_SHIFT    20
>> +
>> +#define TLBMISC_PID  (TLBMISC_PID_MASK << TLBMISC_PID_SHIFT) /* TLB PID */
>> +#define TLBMISC_WE   (1 << 18)       /* TLB write enable */
>> +#define TLBMISC_RD   (1 << 19)       /* TLB read */
>> +#define TLBMISC_WAY  (TLBMISC_WAY_MASK << TLBMISC_WAY_SHIFT) /* TLB way */
>> +
>> +#endif /* _ASM_NIOS2_REGISTERS_H */

>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/