Re: [PATCH RFC 2/2] ARM: shmobile: armadillo800eva defconfig: Enable REGULATOR_GPIO and LEDS_GPIO

[Geert Uytterhoeven]

Hi Simon,

On Wed, Apr 23, 2014 at 2:50 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote:
> On Tue, Apr 22, 2014 at 03:01:07PM +0200, Geert Uytterhoeven wrote:
>> Refresh armadillo800eva_defconfig, and enable missing options for devices
>> in platform data and/or DT:
>>   - REGULATOR_GPIO
>>   - LEDS_GPIO
>
> I would prefer if changes were made in a more incremental patch.
>
> * A patch to enable LEDS_GPIO and REGULATOR_GPIO.

OK, will do for v2, when I know more about SHMOBILE_IOMMU.

> * Then a cleanup patch, if you really want to do that: but why?

It's a good idea to run a "make savedefconfig" once in a while, to get rid of
stale symbols, and symbols that are now auto-selected.
Anyway, although there were quite some changes in the actual defconfig, the
net impact on "make armadillo800eva_defconfig" is much smaller than I expected
(only CONFIG_NET_VENDOR_SAMSUNG gets enabled), so I'll leave the regular
refreshing to you ;-

>> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>> ---
>> Do we want SHMOBILE_IOMMU, too? The help text says "If unsure, say N."
>> If yes, is the default SHMOBILE_IOMMU_ADDRSIZE_2048MB OK?
>
> I defer to Magnus on that one.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/