Re: [PATCH RESEND 1/2] rtc: 88pm860x: Use of_get_child_by_name

[Jingoo Han]

On Wednesday, April 23, 2014 9:29 PM, Krzysztof Kozlowski wrote:
> 
> Use of_get_child_by_name to obtain reference to charger node instead of
> of_find_node_by_name which can walk outside of the parent node.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>

Reviewed-by: Jingoo Han <jg1.han@xxxxxxxxxxx>

Best regards,
Jingoo Han

> ---
>  drivers/rtc/rtc-88pm860x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-88pm860x.c b/drivers/rtc/rtc-88pm860x.c
> index 816504846cdd..fb9e3c63b4ac 100644
> --- a/drivers/rtc/rtc-88pm860x.c
> +++ b/drivers/rtc/rtc-88pm860x.c
> @@ -293,7 +293,7 @@ static int pm860x_rtc_dt_init(struct platform_device *pdev,
>  	int ret;
>  	if (!np)
>  		return -ENODEV;
> -	np = of_find_node_by_name(np, "rtc");
> +	np = of_get_child_by_name(np, "rtc");
>  	if (!np) {
>  		dev_err(&pdev->dev, "failed to find rtc node\n");
>  		return -ENODEV;
> --
> 1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/