Re: [PATCH v6 15/19] usb: phy: msm: Fix PTS definitions for MSM USB controller

From: Ivan T. Ivanov
Date: Wed Apr 23 2014 - 09:36:39 EST


On Wed, 2014-04-23 at 16:24 +0300, Ivan T. Ivanov wrote:

> > > --- a/include/linux/usb/msm_hsusb_hw.h
> > > +++ b/include/linux/usb/msm_hsusb_hw.h
> > > @@ -31,8 +31,9 @@
> > > #define USB_USBINTR (MSM_USB_BASE + 0x0148)
> > >
> > > #define PORTSC_PHCD (1 << 23) /* phy suspend mode */
> > > -#define PORTSC_PTS_MASK (3 << 30)
> > > -#define PORTSC_PTS_ULPI (3 << 30)
> > > +#define PORTSC_PTS_MASK (3 << 30)
> > > +#define PORTSC_PTS_ULPI (2 << 30)
> > > +#define PORTSC_PTS_SERIAL (3 << 30)
> >
> > Please use tabs, not spaces here.
>
> Thanks, will fix and resend.

I answered too quickly. File contain tabs and spaces for
indentation of definitions. Should I still use tabs here?

Regards,
Ivan

>
> Ivan
>
> >
> > WBR, Sergei
> >
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/