Re: [PATCH v2 2/2] ARM: dts: berlin: enable SD card reader and eMMC for the BG2Q DMP

From: Antoine Ténart
Date: Wed Apr 23 2014 - 13:36:43 EST


Sebastian,

On Wed, Apr 23, 2014 at 07:26:23PM +0200, Sebastian Hesselbarth wrote:
> On 04/22/2014 10:27 AM, Antoine Ténart wrote:
> > Enable the SD Card reader and the internal eMMC on the Berlin BG2Q DMP
> > using two of the SDHCI nodes of the Berlin BG2Q.
> >
> > Signed-off-by: Antoine Ténart <antoine.tenart@xxxxxxxxxxxxxxxxxx>
> > ---
> > arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
> > index 2da9c41e29d8..6ca8c9e52b08 100644
> > --- a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
> > +++ b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
> > @@ -26,3 +26,14 @@
> > &uart0 {
> > status = "okay";
> > };
> > +
> > +&sdhci1 {
>
> Antoine,
>
> nit: please sort referenced nodes alphabetically.
>
> With your comments about mmc aliases, I can take both patches
> in now (and fixup ordering) if you like.

You can take them.

I talked with Jisheng about this and the plan is to make a following up
series for the aliases since it will require to modify the subsystem.

Thanks!

Antoine

>
> Sebastian
>
> > + broken-cd;
> > + sdhci,wp-inverted;
> > + status = "okay";
> > +};
> > +
> > +&sdhci2 {
> > + non-removable;
> > + status = "okay";
> > +};
> >
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/