Re: [PATCH] net/phy: micrel: fix bugged test on device tree loading for ksz9021

From: David Miller
Date: Wed Apr 23 2014 - 14:59:36 EST


From: Hubert Chaumette <hchaumette@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 22 Apr 2014 15:01:04 +0200

> In ksz9021_load_values_from_of() val2 to val4 aren't tested against their
> initialization value.
> This causes the test to always succeed, and this value to be used as if it
> was loaded from the devicetree instead of being ignored, in case of a
> missing/invalid property in the ethernet OF device node.
> As a result, the value "0" is written to the relevant registers.
>
> Change the conditions to test against the right initialization value.
>
> Signed-off-by: Hubert Chaumette <hchaumette@xxxxxxxxxxxxxxxxxxx>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/