Re: [PATCH 1/4] memcg, mm: introduce lowlimit reclaim
From: Michal Hocko
Date: Fri May 02 2014 - 11:49:00 EST
On Fri 02-05-14 11:34:51, Johannes Weiner wrote:
> On Fri, May 02, 2014 at 05:11:20PM +0200, Michal Hocko wrote:
> > On Fri 02-05-14 11:04:34, Johannes Weiner wrote:
> > [...]
> > > > @@ -2236,12 +2246,9 @@ static unsigned __shrink_zone(struct zone *zone, struct scan_control *sc,
> > > > do {
> > > > struct lruvec *lruvec;
> > > >
> > > > - /*
> > > > - * Memcg might be under its low limit so we have to
> > > > - * skip it during the first reclaim round
> > > > - */
> > > > - if (follow_low_limit &&
> > > > - !mem_cgroup_reclaim_eligible(memcg, root)) {
> > > > + /* Memcg might be protected from the reclaim */
> > > > + if (force_memcg_guarantee &&
> > >
> > > respect_? consider_?
> >
> > enforce_ ?
>
> A native speaker might be better at this, but to me it seems weird to
> enforce a promise. honor_memcg_guarantee?
OK, will go with honor. Thanks!
---