Re: [PATCH 1/1] block/blk-core.c: convert printk to pr_foo()

[Fabian Frederick]

On Fri, 02 May 2014 11:39:44 -0600
Jens Axboe <axboe@xxxxxxxxx> wrote:

> On 05/02/2014 10:49 AM, Fabian Frederick wrote:
> > -Convert all printk,print_ratelimited ...
> > -Define debug to have pr_debug emitted
> > -Fix checkpatch warning: Lu->llu
> > 
> > Cc: Jens Axboe <axboe@xxxxxxxxx>
> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>
> > ---
> >  block/blk-core.c | 60 +++++++++++++++++++++++++++-----------------------------
> >  1 file changed, 29 insertions(+), 31 deletions(-)
> > 
> > diff --git a/block/blk-core.c b/block/blk-core.c
> > index a0e3096..5c544fa 100644
> > --- a/block/blk-core.c
> > +++ b/block/blk-core.c
> > @@ -11,6 +11,7 @@
> >  /*
> >   * This handles all read/write requests to block devices
> >   */
> > +#define DEBUG
> >  #include <linux/kernel.h>
> >  #include <linux/module.h>
> >  #include <linux/backing-dev.h>
> 
> That's a mess.

Other solutions are 
1) Leave the only printk(KERN_DEBUG as it is.
2) Add BLK-CORE-DEBUG in Kconfig


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/