Re: [tip:locking/core] rwsem: Add comments to explain the meaning of the rwsem's count field

[Tim Chen]

On Mon, 2014-05-05 at 18:31 +0200, Peter Zijlstra wrote:
> On Mon, May 05, 2014 at 09:03:28AM -0700, Tim Chen wrote:
> > On Mon, 2014-05-05 at 01:46 -0700, tip-bot for Tim Chen wrote:
> > > Commit-ID:  3cf2f34e1a3d4d5ff209d087925cf950e52f4805
> > > Gitweb:     http://git.kernel.org/tip/3cf2f34e1a3d4d5ff209d087925cf950e52f4805
> > > Author:     Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx>
> > > AuthorDate: Fri, 2 May 2014 12:53:57 -0700
> > > Committer:  Ingo Molnar <mingo@xxxxxxxxxx>
> > > CommitDate: Sun, 4 May 2014 20:34:26 +0200
> > > 
> > 
> > Ingo,
> > 
> > Can you pick up this version of the patch instead.  I've updated the
> > comments to reflect all cases for which the rwsem's count is less than
> > WAITING_BIAS, as Peter has pointed out.
> 
> Wouldn't a state diagram be clearer than this gobs of text?

The state is represented by the count field with an explanation
of what each state actually means.  I started off with a
pretty abbreviated version. But to account for the readers and writers
that are in transient trying to acquire the lock, the comments
get more verbose, unfortunately.

Tim

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/