Re: [PATCH RFC/TEST] sched: make sync affine wakeups work

[Peter Zijlstra]

On Tue, May 06, 2014 at 04:19:21PM -0400, Rik van Riel wrote:
> On 05/06/2014 07:54 AM, Peter Zijlstra wrote:
> > On Fri, May 02, 2014 at 11:19:47AM -0400, Rik van Riel wrote:
> >> As an aside, it also looks like SD_BALANCE_WAKE is set on all domains
                                     ^^^^^^^^^^^^^^^

> >> of a NUMA system by default, so even the non-affine wakeup will end
> >> up looking for the lowest load NUMA node to start up on.
> > 
> > I can't find it being set on anything by default.
> 
>                 .flags                  = 1*SD_LOAD_BALANCE
>                                         | 1*SD_BALANCE_NEWIDLE
>                                         | 0*SD_BALANCE_EXEC
>                                         | 0*SD_BALANCE_FORK
>                                         | 0*SD_BALANCE_WAKE

                                            ^

last time I checked 0*x was still 0.

>                                         | 0*SD_WAKE_AFFINE
>                                         | 0*SD_SHARE_CPUPOWER
>                                         | 0*SD_SHARE_PKG_RESOURCES
>                                         | 1*SD_SERIALIZE
>                                         | 0*SD_PREFER_SIBLING
>                                         | 1*SD_NUMA
>                                         | sd_local_flags(level)
> 
> 
> static inline int sd_local_flags(int level)
> {
>         if (sched_domains_numa_distance[level] > RECLAIM_DISTANCE)
>                 return 0;
> 
>         return SD_BALANCE_EXEC | SD_BALANCE_FORK | SD_WAKE_AFFINE;
> }

No BALANCE_WAKE there
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/