Re: [RFC PATCH] cpufreq: intel_pstate: Change the calculation of next pstate

[Yuyang Du]

> > > Maybe, in some cases yes. But not always. 
> > > For example, please consider a CPU running a tight "for" loop in 100MHz 
> > > for a couple of seconds. This produces a load of 100%. 
> > > It will produce the same load (100%) in any other frequency. 
> >
> > Still fundamentally wrong, because you are not making a fair 
> > comparison ("load" in 100MHz vs. any other freq). 
> >
> 
> I'm sorry, I didn't understand you. What do you mean it's not fair?
> 
> In the above example (considering a CPU with min freq 100MHz and max freq 1000Mhz) a load of 100% should also be 100 in other next frequency.
> 
> If we scale the load we will calculate the load in 100Mhz to 10%. I believe that this is not true.

The amount of work @100MHz is the same as the amount of work @1000MHZ, in your
example? Put another way, your proposed method does not do any extra better,
but do worse in other cases (what if @1000MHz, the load drops to 10%).

That said, your case cannot be used against associating freq with load. That also
said, by associating freq with load, we will finally get highest freq as well
(in your case).

Yuyang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/