Re: [PATCH 2/2] fs: print a message when freezing/unfreezing filesystems
From: Mateusz Guzik
Date: Tue May 13 2014 - 15:06:58 EST
On Tue, May 13, 2014 at 12:00:21PM -0700, Joe Perches wrote:
> On Tue, 2014-05-13 at 20:53 +0200, Mateusz Guzik wrote:
> > This is the same code which you can find at the end of the function.
> > I added the label so that I can write freeze printk only once.
>
> Yes, but for a read-only filesystem is the message useful?
>
I see no harm in printing it and it seems more correct given that
s_writers.frozen changed, but I'm fine either way.
btw, I just noticed a copy-pasto - the same message for freezing and
unfreezing found its way into the patch. sigh.
--
Mateusz Guzik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/