Re: [PATCH 1/3] FS/CODA: replace printk by pr_foo()

[Joe Perches]

On Tue, 2014-05-13 at 14:16 -0400, Jan Harkes wrote:
> On Tue, May 13, 2014 at 06:49:09PM +0200, Fabian Frederick wrote:
> > No level printk converted to pr_warn or pr_info
> > 
> > Cc: Jan Harkes <jaharkes@xxxxxxxxxx>
> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>
> > ---
> 
> Ack, those are nice cleanups for those ugly printk's. Looks like it will
> shave off a few KB of memory too by making the strings shorter.

No.  It doesn't really.

pr_fmt prefaces the format strings with the same
content so there's no actual reduction.

One year soon, I could submit a patch that adds
a generic mechanism to printk which would get the
module name (and function name too) from kallsyms
when pr_fmt is #defined as
	#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
and it's actually compiled as a module.

That would reduce the format string lengths.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/