Re: [PATCH v1 01/11] ARM: amba: Add Qualcomm vendor ID.

From: Stephen Boyd
Date: Tue May 13 2014 - 18:14:24 EST


On 05/13, Srinivas Kandagatla wrote:
> Thanks Linus W,
>
> On 13/05/14 08:16, Linus Walleij wrote:
> >On Tue, Apr 29, 2014 at 10:19 AM, <srinivas.kandagatla@xxxxxxxxxx> wrote:
> >
> >>From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> >>
> >>This patch adds Qualcomm amba vendor Id to the list. This ID is used in mmci
> >>driver.
> >>
> >>Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> >(...)
> >>+ AMBA_VENDOR_QCOM = 0x51,
> >
> >Yeah it's a "Q", like 0x41 is "A" for ARM. You could as well mention
> >this in the commit message.
> >
> Sounds good, I will fix it in next version and send it to Russell's
> patch tracker.
>

Please add a note that this id is fake in the commit text or in
the code as well.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/