Re: [PATCH 2/2] FS/CONFIGFS: Use pr_fmt

[Andrew Morton]

On Tue, 13 May 2014 18:06:50 -0400 Valdis.Kletnieks@xxxxxx wrote:

> On Tue, 13 May 2014 13:50:49 -0700, Andrew Morton said:
> > On Tue, 13 May 2014 20:24:28 +0200 Fabian Frederick <fabf@xxxxxxxxx> wrote:
> 
> > > +#ifdef pr_fmt
> > > +#undef pr_fmt
> > > +#endif
> >
> > Why this?
> >
> > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> 
> Won't GCC whinge by default about the #define if it doesn't exactly match the
> previous definition?

Yes, if there's already a pf_fmt defined.  That's what I'm asking about
- what pr_fmt are we overriding here?  Seems wrong.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/