Re: [PATCH 06/20] perf tools: Consolidate output field handling to hpp format routines

[Namhyung Kim]

On Thu, 15 May 2014 14:07:04 +0200, Jiri Olsa wrote:
> On Mon, May 12, 2014 at 03:28:39PM +0900, Namhyung Kim wrote:
>
> SNIP
>
>> -		}
>> -
>>  		if (symbol_conf.use_callchain && sort__has_sym) {
>>  			if (callchain_param.mode == CHAIN_GRAPH_REL)
>>  				total = h->stat.period;
>> diff --git a/tools/perf/ui/hist.c b/tools/perf/ui/hist.c
>> index c65a7fd744c6..32d2dfd794d9 100644
>> --- a/tools/perf/ui/hist.c
>> +++ b/tools/perf/ui/hist.c
>> @@ -352,8 +352,18 @@ LIST_HEAD(perf_hpp__sort_list);
>>  #undef __HPP_ENTRY_RAW_FN
>>  
>>  
>> +void perf_hpp__setup_output_field(void);
>
> should go to util/hist.h

Okay.

>
>>  {
>> diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c
>> index 9eccf7f4f367..e6920d124c60 100644
>> --- a/tools/perf/ui/stdio/hist.c
>> +++ b/tools/perf/ui/stdio/hist.c
>> @@ -353,8 +353,7 @@ static int hist_entry__fprintf(struct hist_entry *he, size_t size,
>>  	if (size == 0 || size > bfsz)
>>  		size = hpp.size = bfsz;
>>  
>> -	ret = hist_entry__period_snprintf(&hpp, he);
>> -	hist_entry__sort_snprintf(he, bf + ret, size - ret, hists);
>> +	hist_entry__period_snprintf(&hpp, he);
>
> so it's no longer just period.. should we rename it? like
>   hist_entry__hpp_snprintf
>   hist_entry__snprintf

The hist_entry__snprintf() looks better to me.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/