Re: [PATCH 06/20] perf tools: Consolidate output field handling to hpp format routines

[Namhyung Kim]

On Thu, 15 May 2014 14:11:52 +0200, Jiri Olsa wrote:
> On Mon, May 12, 2014 at 03:28:39PM +0900, Namhyung Kim wrote:
>
> SNIP
>
>> diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c
>> index 9eccf7f4f367..e6920d124c60 100644
>> --- a/tools/perf/ui/stdio/hist.c
>> +++ b/tools/perf/ui/stdio/hist.c
>> @@ -353,8 +353,7 @@ static int hist_entry__fprintf(struct hist_entry *he, size_t size,
>>  	if (size == 0 || size > bfsz)
>>  		size = hpp.size = bfsz;
>>  
>> -	ret = hist_entry__period_snprintf(&hpp, he);
>> -	hist_entry__sort_snprintf(he, bf + ret, size - ret, hists);
>> +	hist_entry__period_snprintf(&hpp, he);
>
> hm, how about hist_browser__fprintf_entry.. looks like it could

The term 'hist_browser' is for some browsable UI windows like in TUI or
GUI IMHO.  So I think simply call it as hist_entry__snprintf() is better
as you originally suggested.


> use just hist_entry__period_snprintf as well and we could get rid
> hist_entry__sort_snprintf completely

Hmm.. right.  It'll be gone eventually.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/