Re: [PATCH] openrisc: irq: use irqchip framework

[Jonas Bonn]

Hi Stefan,

This looks good.  Let's complete the the cleanup of this driver while
we're at it:

i) Move this file to drivers/irqchip/
ii) Put a Depends on CONFIG_ARCH_OPENRISC in the Kconfig
iii) Provide documentation for the binding at
Documentation/devicetree/bindings/interrupt-controller/

Copy final result to Thomas Gleixner who maintains the irqchip bits.

Thanks,
Jonas

On 05/19/2014 02:25 PM, Stefan Kristiansson wrote:
> In addition to consolidating the or1k-pic initialization with
> how other interrupt controllers are initialized, this makes
> OpenRISC less tied to its on-cpu interrupt controller.
> 
> Signed-off-by: Stefan Kristiansson <stefan.kristiansson@xxxxxxxxxxxxx>
> ---
>  arch/openrisc/kernel/irq.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/openrisc/kernel/irq.c b/arch/openrisc/kernel/irq.c
> index 8ec77bc..f6f4683 100644
> --- a/arch/openrisc/kernel/irq.c
> +++ b/arch/openrisc/kernel/irq.c
> @@ -19,10 +19,13 @@
>  #include <linux/of.h>
>  #include <linux/ftrace.h>

Do we really need to pull in ftrace.h?

<snip>

This last bit (below) stays in the arch/openrisc directory.

>  void __init init_IRQ(void)
>  {
> -	or1k_irq_init();
> +	irqchip_init();
>  }
>  
>  void __irq_entry do_IRQ(struct pt_regs *regs)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/