Re: [PATCH 1/9] staging: ion: tidy up a bit

From: Dan Carpenter
Date: Mon May 26 2014 - 06:36:41 EST


On Mon, May 26, 2014 at 07:04:53PM +0900, Heesub Shin wrote:
> @@ -124,7 +122,6 @@ static struct page_info *alloc_largest_available(struct ion_system_heap *heap,
>
> info->page = page;
> info->order = orders[i];
> - INIT_LIST_HEAD(&info->list);
> return info;
> }
> kfree(info);

Wait. How does this code work without that INIT_LIST_HEAD()? What am
I missing here...

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/