Re: [PATCH 1/9] staging: ion: tidy up a bit

[Heesub Shin]

Hello Carpenter,

On 05/26/2014 07:36 PM, Dan Carpenter wrote:
> On Mon, May 26, 2014 at 07:04:53PM +0900, Heesub Shin wrote:
> > @@ -124,7 +122,6 @@ static struct page_info *alloc_largest_available(struct ion_system_heap *heap,
> >
> >   		info->page = page;
> >   		info->order = orders[i];
> > -		INIT_LIST_HEAD(&info->list);
> >   		return info;
> >   	}
> >   	kfree(info);
>
> Wait.  How does this code work without that INIT_LIST_HEAD()?  What am
> I missing here...

No problem. As the object info is just a node, not a head, it is 
completely useless to initialize it as a list head.

regards,
Heesub

> regards,
> dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/