Re: [PATCH 1/1] PINCTRL: Warn if direct IRQ GPIO set to output

[Linus Walleij]

On Tue, May 27, 2014 at 9:26 PM,  <eric.ernst@xxxxxxxxxxxxxxx> wrote:

> From: Eric Ernst <eric.ernst@xxxxxxxxxxxxxxx>
>
> For Baytrail, you should never set a GPIO set to direct_irq
> to output mode.  When direct_irq_en is set for a GPIO, it is
> tied directly to an APIC internally, and making the pad output
> does not make any sense. Assert a WARN() in the event this happens.
>
> Signed-off-by: Eric Ernst <eric.ernst@xxxxxxxxxxxxxxx>

Can I get some ACK from the author's of this driver on Eric's patch?

Eric, you *are* aware of what the gpio_lock_as_irq() and
gpio_unlock_as_irq() in the .irq_request_resources are doing
right? Is this patch just some extra safety measure?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/