Re: [PATCH] net-sysfs: Report link speed as signed integer

[Michal Privoznik]

On 02.06.2014 20:10, David Miller wrote:
> From: Veaceslav Falico <vfalico@xxxxxxxxxx>
> Date: Mon, 2 Jun 2014 17:01:50 +0200
>
> > I wonder, though, if we should document it or just output "Unknown"
> > instead of -1.
>
> All of this discussion means that we can't change the format string
> without potentially breaking something out there interpreting the -1
> value, however it gets output now.

No, the discussion means reporting -1 as link speed is confusing.

> I think we just have to leave things as-is and document them in the
> sysfs ABI docs.

Well, that's rather unpleasant.

> I'm not applying this patch.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/