Re: [PATCH] net-sysfs: Report link speed as signed integer

[Michal Privoznik]

On 03.06.2014 09:07, Michal Privoznik wrote:
> On 02.06.2014 20:10, David Miller wrote:
> > From: Veaceslav Falico <vfalico@xxxxxxxxxx>
> > Date: Mon, 2 Jun 2014 17:01:50 +0200
> >
> > > I wonder, though, if we should document it or just output "Unknown"
> > > instead of -1.
> >
> > All of this discussion means that we can't change the format string
> > without potentially breaking something out there interpreting the -1
> > value, however it gets output now.

One more thing. The commit that changed the behavior is 8ae6daca which 
is part of the 3.0 release. So any 2.6.X kernel does report -1 while 
with 3.Y kernel you'll get this meaningless value. Having said that, we 
already broke the applications so how about unbreaking them?

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/