Re: [PATCH] lib.c: skip --param parameters

From: Josh Triplett
Date: Mon Jun 16 2014 - 22:37:03 EST


On Mon, Jun 16, 2014 at 04:48:51PM -0700, David Rientjes wrote:
> On Mon, 16 Jun 2014, Josh Triplett wrote:
>
> > On Mon, Jun 16, 2014 at 01:43:06PM +0300, Andy Shevchenko wrote:
> > > Very dumb patch to just skip --param allow-store-data-races=0 introduced in
> > > newest Linux kernel buildsystem.
> > >
> > > Actually the option is present in few GCC versions and probably should be
> > > handled properly.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> >
> > As far as I can tell, this seems to only handle "--param arg"; however,
> > according to the thread on LKML, GCC handles --param=arg as well. Could
> > you please handle that variant too?
> >
>
> This is only from linux-next and not Linus's tree, correct?
>
> Is this still necessary since the "./Makefile: tell gcc optimizer to never
> introduce new data races" patch has been removed from -mm due to failures?
>
> See http://marc.info/?l=linux-mm-commits&m=140295825623471

I'd still like to see Sparse not choke on the option, in either form,
whether the kernel ends up using it or not.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/