Re: [PATCH] mm/vmscan.c: fix an implementation flaw in proportional scanning

[Chen Yucong]

On Wed, 2014-06-18 at 11:00 +0200, Jerome Marchand wrote:
> >               if (!nr_file || !nr_anon)
> >                       break;
> >  
> > -             if (nr_file > nr_anon) {
> > -                     unsigned long scan_target =
> targets[LRU_INACTIVE_ANON] +
> >
> -                                             targets[LRU_ACTIVE_ANON]
> + 1;
> > +             file_percent = nr_file * 100 / file_target;
> > +             anon_percent = nr_anon * 100 / anon_target;
> 
> Here it could happen.
> 
> 
The snippet 
	...
               if (!nr_file || !nr_anon)
                      break;
        ...
 can help us to filter the situation which you have described. It comes
from Mel's patch that is called:

mm: vmscan: use proportional scanning during direct reclaim and full
scan at DEF_PRIORITY

thx!
cyc

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/