Re: [PATCH net-next v2 3/3] devicetree: add devicetree bindings for cc2520 driver

[Varka Bhadram]

Hi,

On 06/18/2014 02:35 PM, Mark Rutland wrote:
> On Wed, Jun 18, 2014 at 06:16:05AM +0100, Varka Bhadram wrote:
> > devicetree bindings for cc2520 radio driver.
> >
> > Signed-off-by: Varka Bhadram <varkab@xxxxxxx>
> > ---
> >   .../devicetree/bindings/net/ieee802154/cc2520.txt  |   26 ++++++++++++++++++++
> >   1 file changed, 26 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/net/ieee802154/cc2520.txt
> >
> > diff --git a/Documentation/devicetree/bindings/net/ieee802154/cc2520.txt b/Documentation/devicetree/bindings/net/ieee802154/cc2520.txt
> > new file mode 100644
> > index 0000000..f0a749d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/ieee802154/cc2520.txt
> > @@ -0,0 +1,26 @@
> > +CC2520 IEEE 802.15.4 Compatible Radio
> > +
> > +Required properties:
> > +	- compatible:		should be "ti,cc2520"
> > +	- spi-max-frequency:	maximal bus speed (8000000), should be set to 4000000 depends
> > +				sync or async operation mode
> > +	- reg:			the chipselect index
> > +	- mode:			SPI mode
> What exactly is this property? It doesn't seem to be used by the driver,
> the example is opaque, and this doesn't seem to match any existing
> bindings (a grep for "mode" in Documentation/devicetree/bindings/spi
> only found me a string "mode" property).
>
> The example has several properties (the GPIOs and pinctrl) not listed
> here...

Previously is used this 'mode' property to set the SPI mode. but i am not using now. I will remove it.
And also i will add the optional properties GPIO and pinctrl in next version.

Thanks for comments.

-Varka Bhadram.

> Mark.
>
> > +Example:
> > +
> > +	cc2520@0 {
> > +		compatible = "ti,cc2520";
> > +		reg = <0>;
> > +		spi-max-frequency = <4000000>;
> > +		mode = <1>;
> > +
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&cc2520_cape_pins>;	/*GPIO pin muxing details*/
> > +
> > +		fifo-gpio = <&gpio1 18 0>;
> > +		fifop-gpio = <&gpio1 19 0>;
> > +		sfd-gpio = <&gpio1 13 0>;
> > +		cca-gpio = <&gpio1 16 0>;
> > +		vreg-gpio = <&gpio0 31 0>;
> > +		reset-gpio = <&gpio1 12 0>;
> > +	};
> > --
> > 1.7.9.5
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe devicetree" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/