Re: [PATCH v5 01/15] thunderbolt: Add initial cactus ridge NHI support

[Greg KH]

On Fri, Jun 20, 2014 at 09:41:52AM +0200, Paul Bolle wrote:
> On Tue, 2014-06-03 at 22:03 +0200, Andreas Noever wrote:
> > Thunderbolt hotplug is supposed to be handled by the firmware. But Apple
> > decided to implement thunderbolt at the operating system level. The
> > firmare only initializes thunderbolt devices that are present at boot
> > time. This driver enables hotplug of thunderbolt of non-chained
> > thunderbolt devices on Apple systems with a cactus ridge controller.
> > 
> > This first patch adds the Kconfig file as well the parts of the driver
> > which talk directly to the hardware (that is pci device setup, interrupt
> > handling and RX/TX ring management).
> > 
> > Signed-off-by: Andreas Noever <andreas.noever@xxxxxxxxx>
> > ---
> 
> This patch landed in today's linux-next (next-20140620).
> 
> > [...]
> > --- /dev/null
> > +++ b/drivers/thunderbolt/Kconfig
> > @@ -0,0 +1,12 @@
> > +menuconfig THUNDERBOLT
> > +	tristate "Thunderbolt support for Apple devices"
> > +	default no
> 
> That should have been "default n". But "n" is the default anyway, so I'd
> say this line might as well be dropped. Should I draft the trivial patch
> to do that?
> 
> > +	help
> > +	  Cactus Ridge Thunderbolt Controller driver
> > +	  This driver is required if you want to hotplug Thunderbolt devices on
> > +	  Apple hardware.
> > +
> > +	  Device chaining is currently not supported.
> > +
> > +	  To compile this driver a module, choose M here. The module will be
> > +	  called thunderbolt.
> 
> (Naive question: is Thunderbolt relevant outside x86_64?)

It could be, if someone makes a board for it, I don't see anything on it
that is x86-specific.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/