Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

[Guenter Roeck]

On 06/23/2014 03:31 AM, Maxime Ripard wrote:
> On Thu, May 22, 2014 at 02:12:07PM -0700, Guenter Roeck wrote:
> > On Thu, May 22, 2014 at 10:34:44PM +0200, Maxime Ripard wrote:
> > > On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote:
> > > > On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote:
> > > > > On Wed, May 07, 2014 at 02:33:18PM -0700, Guenter Roeck wrote:
> > > > > > On Tue, May 06, 2014 at 09:44:19PM -0500, Maxime Ripard wrote:
> > > > > > > Most of the watchdog code is duplicated between the machine restart code and
> > > > > > > the watchdog driver. Add the restart hook to the watchdog driver, to be able to
> > > > > > > remove it from the machine code eventually.
> > > > > > >
> > > > > > > Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
> > > > > > > Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
> > > > > >
> > > > > > Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > > > >
> > > > > Wim, do you have any comment on this one?
> > > >
> > > > Ping?
> > > >
> > > > It would be really great to see this in 3.16, and we get quite close
> > > > to the end of ARM's merge window.
> > >
> > > Ping?
> > >
> > > Guenter, since you seem to be the only responsive, may I suggest that
> > > you start merging patches and do a pull request to either Wim or Linus
> > > directly during the merge window?
> > I had prepared a pull request for Wim last weekend or so, but then there
> > were more patches piling in and I got distracted, so I didn't have time
> > to actually send it. I'll try again this weekend ... the kids should be
> > busy learning for their finals, and I'll have Friday and Monday off
> > from work, so I should be able to find the time.
> >
> > As for sending patches to Linus directly, well, Wim is the watchdog maintainer.
> > I manage to upset enough people, and would not want to add Wim to the list.
> >
> > The patches _are_ in my watchdog-next branch and get some coverage from
> > both my auto-builders and from Fenguang's build robots, so while they are
> > not in linux-next, they are not completely in the dark either.
>
> So, this patch finally didn't make it into 3.16. Great. Now, we can't
> even reboot the boards.
>
> Given how it's just impossible to get something merged reliably
> through the watchdog tree, I guess I should just start merging the
> patches through mine?

You can not really blame Wim here.

In this case, I suspect the major reason for not accepting the patch
is that I tried to provide a clean method / API for "reset through watchdog
subsystem", which went nowhere, in my understanding because someone objected
that it would be the wrong thing to do [1] and it didn't get approval /
acceptance from the arm maintainers. If it is wrong to reset the board
from the watchdog subsystem in a clean way, it is for sure even more wrong
to do it as you proposed in your patch.

My conclusion therefore is that all board reset code should move back out
of the watchdog subsystem, and that we should not accept such code in the
future. This is not my personal preference, but I do believe that we should
do it in a clean way or not at all.

Guenter

---
[1] https://lkml.org/lkml/2014/5/15/838
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/