Re: [PATCH] pwm-backlight: use devm_gpiod_get_optional()
From: Thierry Reding
Date: Fri Jun 27 2014 - 02:13:57 EST
On Wed, Jun 25, 2014 at 01:03:31PM +0100, Lee Jones wrote:
> On Wed, 25 Jun 2014, Thierry Reding wrote:
> > On Wed, Jun 25, 2014 at 10:54:47AM +0100, Lee Jones wrote:
> > > > Make use of the new devm_gpiod_get_optional() to simplify the probe
> > > > code.
> > > >
> > > > Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> > > > ---
> > > > drivers/video/backlight/pwm_bl.c | 7 ++-----
> > > > 1 file changed, 2 insertions(+), 5 deletions(-)
> > >
> > > Looks good. Applied, thanks.
> >
> > Technically pwm_bl.c is my turf. However I only adopted it way back when
> > the backlight subsystem was orphaned, but it seems Jingoo, Bryan and you
> > are taking good care of it these days, so perhaps it would be a good
> > idea to move it back to your custody?
>
> Yeah, the whole 'driver maintainer' sketch could get pretty complex.
> It's pretty clean-cut in the PWM subsystem as only one exists, but
> Backlight and MFD have a whole bunch, and I don't usually wait for
> them to Ack/Nack before applying or providing review comments.
>
> I'm happy to play it however you like really. I'm sure the boys and I
> can handle it if you so wish. Even better if you would say in the
> MAINTAINERS file and provide review comments when patches are
> submitted. I do think all 'drivers/video/backlight' changes should go
> in via the Backlight tree though.
Okay, that works for me.
Thierry
Attachment:
pgp__5J2unInI.pgp
Description: PGP signature