Re: [PATCH v2 05/12] usb: phy: add the Berlin USB PHY driver

From: Felipe Balbi
Date: Fri Jun 27 2014 - 19:05:27 EST


On Fri, Jun 27, 2014 at 06:05:57PM +0200, Antoine Ténart wrote:
> Hi Felipe,
>
> On Fri, Jun 27, 2014 at 10:56:22AM -0500, Felipe Balbi wrote:
> > On Tue, Jun 24, 2014 at 12:35:14PM +0200, Antoine Ténart wrote:
> > > Add the driver driving the Marvell Berlin USB PHY. This allows to
> > > initialize the PHY and to use it from the USB driver later.
> > >
> > > Signed-off-by: Antoine Ténart <antoine.tenart@xxxxxxxxxxxxxxxxxx>
> >
> > since this is a brand new driver, it should go to drivers/phy instead.
>
> This PHY is used by a ChipIdea USB driver, which uses the provided
> common function for ChipIdea. These functions use the usb_phy framework.
> That's why this PHY driver is there.

right, but you can add support for the new PHY layer which would help
other users convert their PHY drivers to the new PHY framework.

--
balbi

Attachment: signature.asc
Description: Digital signature