Re: [PATCH 05/18] perf tools: Add ordered_events_(get|put) interface

[David Ahern]

On 6/18/14, 8:58 AM, Jiri Olsa wrote:
> +static struct ordered_event*
> +ordered_events_get(struct ordered_events_queue *q, u64 timestamp)
> +{
> +	struct ordered_event *new;
> +
> +	new = alloc_event(q);
> +	if (new) {
> +		new->timestamp = timestamp;
> +		queue_event(q, new);
> +	}
> +
> +	return new;
> +}

The _get name does not really correlate with what is happening -- ie., 
allocate a new event and add it to the queue. There is no reference 
taken either.

> +
> +static void
> +ordered_event_put(struct ordered_events_queue *q, struct ordered_event *iter)
> +{
> +	list_del(&iter->list);
> +	list_add(&iter->list, &q->cache);
> +	q->nr_events--;
> +}

Similarly here with the _put. In this case the function is moving the 
event from one list to another. And how about something else for the 
name besides iter -- oe, or oevent?

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/