Re: [PATCH] regulator: core: Still free GPIOs using gpio_free()

From: Russell King - ARM Linux
Date: Tue Jul 01 2014 - 08:06:37 EST


On Tue, Jul 01, 2014 at 12:55:26PM +0100, Mark Brown wrote:
> From: Mark Brown <broonie@xxxxxxxxxx>
>
> Even though we mostly use GPIO descriptors internally we still use
> gpio_request_one() to request so we need to pair that with gpio_free() to
> release the GPIO.
>
> Reported-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>

This doesn't explain the reason... I see the current GPIO code doing this:

void gpio_free(unsigned gpio)
{
gpiod_free(gpio_to_desc(gpio));
}
EXPORT_SYMBOL_GPL(gpio_free);

--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/