Re: [PATCH v2 3/7] ARM: dts: AM43x: Add TPS65218 device tree nodes

[Felipe Balbi]

On Tue, Jul 08, 2014 at 03:46:33PM +0530, Keerthy wrote:
> Add TPS65218 device tree nodes. i2c clock frequency setting
> also added as part of tps65218 nodes addition. As i2c clock
> enabling is required.
> 
> Signed-off-by: Keerthy <j-keerthy@xxxxxx>
> ---
> 
> Changes in V2:
>   * Added dcdc3, dcdc5, dcdc6 nodes.

It might be worth noting that dcdc4 is missing because of a possible
PMIC bug you're dealing with. Other than that:

Reviewed-by: Felipe Balbi <balbi@xxxxxx>

>  arch/arm/boot/dts/am43x-epos-evm.dts |   59 ++++++++++++++++++++++++++++++++++
>  1 file changed, 59 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts
> index 90098f9..f1ee7495 100644
> --- a/arch/arm/boot/dts/am43x-epos-evm.dts
> +++ b/arch/arm/boot/dts/am43x-epos-evm.dts
> @@ -327,6 +327,65 @@
>  	status = "okay";
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&i2c0_pins>;
> +	clock-frequency = <400000>;
> +
> +	tps65218: tps65218@24 {
> +		reg = <0x24>;
> +		compatible = "ti,tps65218";
> +		interrupts = <GIC_SPI 7 IRQ_TYPE_NONE>; /* NMIn */
> +		interrupt-parent = <&gic>;
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +
> +		dcdc1: regulator-dcdc1 {
> +			compatible = "ti,tps65218-dcdc1";
> +			regulator-name = "vdd_core";
> +			regulator-min-microvolt = <912000>;
> +			regulator-max-microvolt = <1144000>;
> +			regulator-boot-on;
> +			regulator-always-on;
> +		};
> +
> +		dcdc2: regulator-dcdc2 {
> +			compatible = "ti,tps65218-dcdc2";
> +			regulator-name = "vdd_mpu";
> +			regulator-min-microvolt = <912000>;
> +			regulator-max-microvolt = <1378000>;
> +			regulator-boot-on;
> +			regulator-always-on;
> +		};
> +
> +		dcdc3: regulator-dcdc3 {
> +			compatible = "ti,tps65218-dcdc3";
> +			regulator-name = "vdcdc3";
> +			regulator-min-microvolt = <1350000>;
> +			regulator-max-microvolt = <1350000>;
> +			regulator-boot-on;
> +			regulator-always-on;
> +		};
> +
> +		dcdc5: regulator-dcdc5 {
> +			compatible = "ti,tps65218-dcdc5";
> +			regulator-name = "v1_0bat";
> +			regulator-min-microvolt = <1000000>;
> +			regulator-max-microvolt = <1000000>;
> +		};
> +
> +		dcdc6: regulator-dcdc6 {
> +			compatible = "ti,tps65218-dcdc6";
> +			regulator-name = "v1_8bat";
> +			regulator-min-microvolt = <1800000>;
> +			regulator-max-microvolt = <1800000>;
> +		};
> +
> +		ldo1: regulator-ldo1 {
> +			compatible = "ti,tps65218-ldo1";
> +			regulator-min-microvolt = <1800000>;
> +			regulator-max-microvolt = <1800000>;
> +			regulator-boot-on;
> +			regulator-always-on;
> +		};
> +	};
>  
>  	at24@50 {
>  		compatible = "at24,24c256";
> -- 
> 1.7.9.5
> 

-- 
balbi

Attachment: signature.asc
Description: Digital signature