Re: [PATCH v2 6/7] ata: Add support for the Tegra124 SATA controller

From: Mikko Perttunen
Date: Tue Jul 08 2014 - 09:38:59 EST

Thanks, I'll fix these.

On 08/07/14 16:22, Tejun Heo wrote:
(cc'ing Hans)

Hans, can you please review this patch?

On Wed, Jun 18, 2014 at 05:23:25PM +0300, Mikko Perttunen wrote:
+#define SATA_CONFIGURATION_0 0x180

Let's just indent uniformly. The new line should give enough visual
hint on grouping.

+struct tegra_ahci_priv {
+ struct platform_device *pdev;
+ void __iomem *sata_regs;
+ struct reset_control *sata_rst;
+ struct reset_control *sata_oob_rst;
+ struct reset_control *sata_cold_rst;
+ struct clk *sata_clk;
+ struct clk *sata_oob_clk;
+ struct clk *cml1_clk;
+ struct clk *plle_clk;
+ struct regulator_bulk_data supplies[5];
+ struct phy *padctl_phy;

And please indent the declared fields uniformly too.

Except for the above nitpicks, generally looks good to me but let's
wait for Hans' review.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at