Re: [PATCH] modules: Fix build error in moduleloader.h

[Steven Rostedt]

On Tue, 08 Jul 2014 09:10:09 +0930
Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
 
> Subject: modules: Fix build error in moduleloader.h
> 
> Fengguang Wu's build bot detected that if moduleloader.h is included in
> a C file (used by ftrace and kprobes to access module_alloc() when
> available), that it can fail to build if CONFIG_MODULES and
> CONFIG_MODULES_USE_ELF_REL is not defined.
> 
> This is because there's a printk() that dereferences struct module to
> print the name of the module. But as struct module does not exist when
> CONFIG_MODULES is not defined we get this error:
> 
>    include/linux/moduleloader.h: In function 'apply_relocate':
> >> include/linux/moduleloader.h:48:63: error: dereferencing pointer to
> >> incomplete type  
>      printk(KERN_ERR "module %s: REL relocation unsupported\n", me->name);
> 								  ^
> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> Based-on-the-true-story-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

Confirms-rustys-story-ends-the-same-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

-- Steve


> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/